[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] Properly handle funny file names for headers in

From: Benoit Sigoure
Subject: Re: [PATCH v2] Properly handle funny file names for headers in config.status.
Date: Tue, 18 Dec 2007 08:09:21 +0100

On Dec 18, 2007, at 5:33 AM, Eric Blake wrote:

According to Benoit Sigoure on 12/17/2007 9:21 AM:
+# Neutralize special characters interpreted by sed in replacement strings.
+case $configure_input in #(
+  *'&'*) ac_sed_conf_input=`AS_ECHO(["$configure_input"]) |
+                             sed 's/\\\\/\\\\\\\\/g;s/&/\\\\\\&/g'`;;
+  *) ac_sed_conf_input=$configure_input

Missing ;;

How on earth did the test 119 succeed with this obvious syntax error?!

 # Neutralize VPATH when `$srcdir' = `.'.
+# Run the same test a 2nd time to see that config.status does not recreate
+# the header (regression test)
+AT_CHECK([./config.status "--header=$file:$"],
+ [0], [config.status: creating file with funny \ ' \' $ & #!*? name
+config.status: file with  funny \ ' \' $ & #!*? name is unchanged

Unrelated to what you are fixing, but this test also needs factoring into
w32-safe characters, so we might as well do it now; see msg00044.html

OK, let's do it in a separate commit.

Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory

reply via email to

[Prev in Thread] Current Thread [Next in Thread]