[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fix AC_C_CONST to work with CFLAGS -O2 -Wall -Werror

From: Ralf Wildenhues
Subject: Re: fix AC_C_CONST to work with CFLAGS -O2 -Wall -Werror
Date: Sun, 18 May 2008 18:14:26 +0200
User-agent: Mutt/1.5.17+20080114 (2008-01-14)

* Didier Barvaux wrote on Sat, May 10, 2008 at 05:37:25PM CEST:
> --- a/lib/autoconf/c.m4
> +++ b/lib/autoconf/c.m4
> @@ -1587,7 +1587,7 @@ AC_DEFUN([AC_C_CONST],
>  #ifndef __cplusplus
>    /* Ultrix mips cc rejects this.  */
>    typedef int charset[2];
> -  const charset cs;
> +  const charset cs = { 0, 0 };
>    /* SunOS 4.1.1 cc rejects this.  */
>    char const *const *pcpcc;
>    char **ppc;

I'm pretty sure this kind of change has the potential to not any more
expose the compiler bug this originally was done for.  So really the
solution would be to not use AC_C_CONST; Autoconf should warn about it
as obsolete (and not only list it as obsolescent in NEWS) and autoscan
should not recommend it any more.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]