[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: parallel autotest [1/3]: Refactor testsuite driver loop.

From: Eric Blake
Subject: Re: parallel autotest [1/3]: Refactor testsuite driver loop.
Date: Tue, 17 Jun 2008 20:19:34 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20080421 Thunderbird/ Mnenhy/

Hash: SHA1

According to Ralf Wildenhues on 6/17/2008 3:08 PM:
| Hi Eric, and sorry for the delay,

Hi Ralf, and thanks for the ping,

| I've added a comment about the directory structure now and squashed the
| other, previously posted fixes into the updated patch 1/3 below.  I'd
| like to commit this in a couple of days, unless you have objections.

Looks good, except for one last question:

| About this patch series in general, how about if we drop 3/3 for now.
| If you don't like 2/3, then we should discuss how to move forward.
| (Otherwise, take your time with review, there's no need to rush.)

I'll either get to it this week, or I'll have to take you up on your offer
to delay - I'll be on a 2-week vacation starting next week.

| +# Wrap up the test suite with summary statistics.
| +cd "$at_helper_dir"
| +
| +at_pass_list=`for f in */pass; do echo $f; done | sed '/*/d; s,/pass,,'`
| +at_skip_list=`for f in */skip; do echo $f; done | sed '/*/d; s,/skip,,'`
| +at_xfail_list=`for f in */xfail; do echo $f; done | sed '/*/d; s,/xfail,,'`
| +at_xpass_list=`for f in ?/xpass ??/xpass ???/xpass ????/xpass; do
| +              echo $f; done | sed '/?/d; s,/xpass,,'`

Why the inconsistency between */pass and ?/xpass?  Also, are '/*/' and
'/?/' portable patterns in sed, since those are regex metacharacters, or
do we need to play it safe and use '/\*/' and '/\?/'?

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at
Comment: Using GnuPG with Mozilla -


reply via email to

[Prev in Thread] Current Thread [Next in Thread]