Re: [PATCH 2/5] avoid duplicate tests for shell functions

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Paolo Bonzini on 9/18/2008 8:13 AM:
> This one-line patch ensures that if a feature is deemed required,
> its test is not emitted in the suggested tests.  It is not 
> perfect, but it works for the case at hand which is right now
> the most complex use of the _AS_DETECT_BETTER_SHELL machinery.
> 
> A more complete fix would require more m4fu and time that I
> have, sorry. :-(

I'm still thinking about that.  As long as you require a shell fn snippet
before someone else suggests it, then your solution is perfect.  The
problem comes that if someone else suggests the snippet first, then it
still gets duplicated when you later require it.

I'm almost wondering whether this is a use-case for m4_set.  Both
DETECT_REQUIRED and DETECT_SUGGESTED are maintaining a set of snippets to
use, with the further coordination that the output of the DETECT_SUGGESTED
test should exclude any snippets that are in the required set.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkjrXuUACgkQ84KuGfSFAYAacACgxxnFAewbd7OS/fheuwiJkh/H
wFsAn0TAVve8ITUAr+jjeGw611Z9PFUV
=PJ48
-----END PGP SIGNATURE-----