autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] Add and document AS_ME_PREPARE and AS_LINENO_PREPARE


From: Ralf Wildenhues
Subject: Re: [PATCH 2/3] Add and document AS_ME_PREPARE and AS_LINENO_PREPARE
Date: Sun, 12 Oct 2008 15:31:11 +0200
User-agent: Mutt/1.5.17+20080114 (2008-01-14)

Hi,

> Paolo Bonzini writes:
> > 
> > This patch documents $as_me and $LINENO, which are the sole constructs
> > (for now) that explicitly require a *_PREPARE macro because they are
> > variables.  So those are defined without the hyphen and documented.

How about also adding tests for them?

Anything that is documented (and most stuff that is undocumented) but
not explicitly tested basically has to be assumed to be broken.

As a really really minor nit, I noted that commit logs use a bit
different styles.  I'm not sure whether it's worth making a fuss
of it, but I'd volunteer writing a script to convert from ChangeLog
entries to commit log entries if that helps.

In fact, I think this is a good first approximation (note embedded TAB):

git diff HEAD ChangeLog |
sed -n '/^+$/,$s/^+     //p' |
sed '1a\
'

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]