autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] use m4_require to implement AS_REQUIRE


From: Paolo Bonzini
Subject: Re: [PATCH] use m4_require to implement AS_REQUIRE
Date: Mon, 13 Oct 2008 16:33:40 +0200
User-agent: Thunderbird 2.0.0.17 (Macintosh/20080914)

> Assuming that the existing code was not underquoted, then either I
> underquote here, or I do that in m4_require.  I chose to underquote
> here.  I can try the other version, underquoting the _m4_defn in
> m4_require and using [$3] here.

I tried it, and I had to underquote not only the _m4_defn in m4_require
(which might be okay, since defn overquotes), but also the call to
m4_divert_require:

-      [m4_divert_require([_m4_divert_desired], [$1], [$2])])])
+      [m4_divert_require(_m4_divert_desired, [$1], [$2])])])

So I'm inclined to leave it as in the already-posted patch.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]