autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/12] use a shell function for _AC_LINK_IFELSE


From: Eric Blake
Subject: Re: [PATCH 03/12] use a shell function for _AC_LINK_IFELSE
Date: Wed, 22 Oct 2008 18:25:07 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

Paolo Bonzini <bonzini <at> gnu.org> writes:

> >   (exit $ac_status); }])
> 
> in _AC_RUN_LOG_STDERR and _AC_RUN_LOG could also be changed to an
> ac_func_set_status shell function that does just "return $1".  A
> candidate for m4sh maybe?

Absolutely!  Nice catch.  I think an m4sh addition would be nice, whether or 
not we end up using it in _AC_DO.

> 
> Or possibly it can also be replaced simply with "test $ac_status != 0",
> avoiding the zsh bug (even though anyway the buggy shells will be
> skipped by the better-shell test).

That would take a more thorough audit to make sure that no one actually tries 
to parse the different values of $0 after calling _AC_DO and friends.  On the 
other hand, _AC_DO already saves the 0-255 value of interest in $ac_status, so 
it shouldn't matter if we collapse $? to a boolean value instead of preserving 
$ac_status.

-- 
Eric Blake






reply via email to

[Prev in Thread] Current Thread [Next in Thread]