autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Pass CONFIG_SHELL down if provided


From: Paolo Bonzini
Subject: Re: [PATCH] Pass CONFIG_SHELL down if provided
Date: Thu, 30 Oct 2008 15:26:46 +0100
User-agent: Thunderbird 2.0.0.17 (Macintosh/20080914)

Eric Blake wrote:
> Paolo Bonzini <bonzini <at> gnu.org> writes:
> 
>> Subconfigures are invoked with $SHELL, not with $CONFIG_SHELL.  And
>> config.status is also created with
>>
>> #! $SHELL
>>
>> which will not pick the CONFIG_SHELL if it was given by the user on the
>> command line.  So is this patch correct?
> 
> Yes, the concept looks correct.  However, I think you are missing 'export 
> SHELL', which could lead to bugs on the shells where variables imported from 
> the environment but subsequently modified are not passed on to child 
> processes 
> unless re-exported.  Please apply, once you've fixed that.

Okay, I added "export SHELL" to AS_INIT_GENERATED as well.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]