autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Pass CONFIG_SHELL down if provided


From: Eric Blake
Subject: Re: [PATCH] Pass CONFIG_SHELL down if provided
Date: Wed, 12 Nov 2008 06:06:59 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.17) Gecko/20080914 Thunderbird/2.0.0.17 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Paolo Bonzini on 11/12/2008 4:42 AM:
>>> Hmm, you were right: we are still buggy.  M4sh should be the one 
>>> guaranteeing 
>>> that we do SHELL=${CONFIG_SHELL-/bin/sh}, and not autoconf/general.m4.  
>>> Otherwise, AS_INIT_GENERATED is broken when using m4sh but not autoconf, 
>>> and 
>>> when CONFIG_SHELL is not set.
> 
> I fail to understand this.  It is AS_INIT_GENERATED that writes
> 
> SHELL=\${CONFIG_SHELL-$SHELL}
> 
> to config.status.

But who writes it to configure?  Right now, AC_INIT.  But it _should_ be
AS_INIT, otherwise, AS_INIT_GENERATED only works if you call AC_INIT
(which is the wrong dependency).

>> AFAIK it is not easy to portably find out which shell we're under.
> 
> Throwing this in the air: what about the entry value of $_ at the top of
> the script?

Not always present and not necessarily reliable, but it might be helpful.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkka1PMACgkQ84KuGfSFAYBrIwCcD1J/j9LgjdkZbEvWp+KVmW0S
QPsAn1llxd+PEIa1n0Kt4n1NB30qOTQ3
=uUvG
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]