[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Pass CONFIG_SHELL down if provided

From: Paolo Bonzini
Subject: Re: [PATCH] Pass CONFIG_SHELL down if provided
Date: Wed, 12 Nov 2008 15:01:20 +0100
User-agent: Thunderbird (Macintosh/20080914)

Eric Blake wrote:
> According to Paolo Bonzini on 11/12/2008 4:42 AM:
>>>> Hmm, you were right: we are still buggy.  M4sh should be the one 
>>>> guaranteeing 
>>>> that we do SHELL=${CONFIG_SHELL-/bin/sh}, and not autoconf/general.m4.  
>>>> Otherwise, AS_INIT_GENERATED is broken when using m4sh but not autoconf, 
>>>> and 
>>>> when CONFIG_SHELL is not set.
>> I fail to understand this.  It is AS_INIT_GENERATED that writes
>> to config.status.
> But who writes it to configure?  Right now, AC_INIT.  But it _should_ be
> AS_INIT, otherwise, AS_INIT_GENERATED only works if you call AC_INIT
> (which is the wrong dependency).

... but (part of) the point of may patch was exactly to avoid the need
to have that line in the top of M4sh scripts.  But yes, moving it to
AS_INIT is also a possibility.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]