[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Autotest and signal handling

From: Eric Blake
Subject: Re: Autotest and signal handling
Date: Sun, 23 Nov 2008 07:29:07 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20081105 Thunderbird/ Mnenhy/

Hash: SHA1

According to Ralf Wildenhues on 11/23/2008 7:01 AM:
> * Ralf Wildenhues wrote on Sun, Nov 16, 2008 at 10:49:18PM CET:
>> * Eric Blake wrote on Sun, Nov 16, 2008 at 10:24:10PM CET:
>>> What do we do about shells, like ash, that choke on "trap ... TSTP"?
>>> $ ash -c 'trap "" TSTP'
>>> trap: bad signal TSTP
>> Which version is that?  My dash 0.5.4 on GNU/Linux does not do this.
> Ping!

The default ash shipped with cygwin (no version string, but dated 20040127).

> Anyway, my current diff on top of the patch is this.
> - actually try out turning job control on and off: bash with job control
>   --disable'd will exit when 'set -m' is used.
>   This should allow to remove some of the 2>/dev/null redirections.
> - split 'set +x +e', for assumed portability issue.
> - use symbolic signal names in output if possible.
> - disable parallel jobs if no job control.  This is actually only due to
>   your comment; my testing indicates no advantage in doing this: the
>   testsuite passes the signal tests even without job control.  Of
>   course, without job control you won't get reliable C^c processing; but
>   that is the case with or without --jobs=N.  So I'm not all that sure
>   this is desirable.
> - disable parallel jobs if trap does not understand the symbolic names
>   PIPE, TSTP, STOP.  This doesn't actually test whether kill understands
>   them, but I'd really hate to try out 'kill -STOP' anywhere, that's just
>   such a bad idea if there is a remote chance that it could go wrong.
> - typo fixes
> Barring further comments, I will probably commit the patch with this
> squashed in, in a couple of days.  I'll try to test some more systems
> until then.

Sounds fine to me, whether or not I've had a chance to further review
before you commit.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at
Comment: Using GnuPG with Mozilla -


reply via email to

[Prev in Thread] Current Thread [Next in Thread]