autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Quote macro names passed from autom4te to M4


From: Eric Blake
Subject: Re: Quote macro names passed from autom4te to M4
Date: Tue, 27 Jan 2009 16:31:21 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

Peter Breitenlohner <peb <at> mppmu.mpg.de> writes:

> The reason is, that the macro names passed from autom4te to M4 lack proper
> shell quoting.

Nice catch.  I hope you realize, however, that m4 1.4.x does not trace macro 
names invoked via indir (that feature is only present in m4.git).  Therefore, 
even though you can now request the trace for 'AC_LANG_COMPILER(Lang)', the 
trace will never fire unless you are also using a self-built m4 (or if I can 
ever get around to releasing m4 1.6).

> 
> Attached is a small patch (against git as of today) fixing this problem,
> together with a test case.

Even nicer; most people don't go to that much trouble, so it is much 
appreciated.  I would have suggested that you actual use one of the weird macro 
names, except that would make the test dependent on the current m4 version 
installed; but making sure autom4te doesn't crash is at least evidence that 
your patch helped.  Applied with slight modifications (adding a ChangeLog, 
adding you to THANKS, making formatting consistent, updating copyright dates).

-- 
Eric Blake






reply via email to

[Prev in Thread] Current Thread [Next in Thread]