[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: verbose testsuite output contains 1M newlines

From: Ralf Wildenhues
Subject: Re: verbose testsuite output contains 1M newlines
Date: Wed, 15 Apr 2009 20:05:44 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

Hi Eric,

* Eric Blake wrote on Wed, Apr 15, 2009 at 02:47:26PM CEST:
> According to Eric Blake on 4/14/2009 7:17 PM:
> > According to Ralf Wildenhues on 4/14/2009 1:26 PM:
> >> Almost.  It seems inconsistent that only ignore-nolog allows non-text
> >> output.  What about ensuring that std{out,err}-nolog do likewise, by
> >> sending some large lines to all three in a test?
> > 
> > Or even files that lack a trailing newline, or contain non-printing
> > characters (or all three).  I'm working up a test, and will post it, along
> > with the other patches, as a series when I'm complete.
> Here's what I added to the series before pushing.  I don't really know how
> to parse that diff gave reasonable output, as $at_diff may or may not be
> using -u, and may print 'binary files differ' instead of comparing
> contents (not to mention that grep and sed are not required to handle
> binary files).  But by testing that valid binary tests compare equal, and
> slightly modified binary tests compare different, I think I've covered the
> intent that we want autotest to handle non-text files.

Thanks for finishing this, it looks good.

I bet this will evoke some failures on legacy systems.  We'll see.


> >From 7ece247bdd194997f5a79aeaad3e7b02bc7130e2 Mon Sep 17 00:00:00 2001
> From: Eric Blake <address@hidden>
> Date: Wed, 15 Apr 2009 06:38:58 -0600
> Subject: [PATCH] Test that autotest handles binary output.
> * tests/ (Binary output): New test.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]