autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: three tiny doc-only patches


From: Jim Meyering
Subject: Re: three tiny doc-only patches
Date: Sat, 06 Jun 2009 18:47:12 +0200

Eric Blake wrote:
> According to Jim Meyering on 6/6/2009 9:49 AM:
>> I found an old branch with these on it.
>> Any objection or suggestion?
>>
>>
>>    $ $[0] AUTOTEST_PATH=bin
>>
>> -possibly amounts into
>> +is equivalent to this, when run from /tmp/foo-1.0:
>>
>> -  PATH=/tmp/foo-1.0/bin:/src/foo-1.0/bin:\$PATH
>> +  PATH=/tmp/foo-1.0/bin:/src/foo-1.0/bin:\$PATH $[0]
>
> That assumes a VPATH build with /src as the --srcdir and /tmp as the build
> location, but the addition of $0 to the output does make it read better.
>
>>>From 58bfc2249179517831fb248a17e910b4ab010afe Mon Sep 17 00:00:00 2001
>> From: Jim Meyering <address@hidden>
>> Date: Wed, 10 Dec 2008 09:58:09 +0100
>> Subject: [PATCH 2/3] * doc/gnu-oids.texi: Remove trailing blank and trailing 
>> empty line.
>
> No.  This file is pulled from upstream, via 'make fetch', and will just
> revert during the next pull.  Besides, .gitattributes already exempts it.
>  The proper fix would need to be fed upstream.
>
>>>From 76a1b4c3abd3bca0db498ef00bf94a8396613b01 Mon Sep 17 00:00:00 2001
>> From: Jim Meyering <address@hidden>
>> Date: Wed, 10 Dec 2008 10:19:16 +0100
>> Subject: [PATCH 3/3] testsuite--help
>
> That subject line could use a space.
>
>>    $ $[0] AUTOTEST_PATH=bin
>>
>> -is equivalent to this, when run from /tmp/foo-1.0:
>> +is equivalent to this, where /src/foo-1.0 is the directory:
>
> s/the directory/the source directory/
>
> With those nits, it means patch 1 and 3 now use consistent wording, so I
> would be okay with squashing those into one patch and applying.  Let me
> know if you want me to do the grunt work.

Thanks for the quick feedback.
How about this:

>From 402f76df382a030b3406004e3746ab97cc36abe3 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Wed, 10 Dec 2008 09:57:30 +0100
Subject: [PATCH] Improve testsuite --help

* lib/autotest/general.m4: Correct the example in ./testsuite --help.
Improve wording.
---
 ChangeLog               |    6 ++++++
 lib/autotest/general.m4 |   11 ++++++-----
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 8a994a9..7139a8e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2009-06-06  Jim Meyering  <address@hidden>
+
+       Improve testsuite --help
+       * lib/autotest/general.m4: Correct the example in ./testsuite --help.
+       Improve wording.
+
 2009-05-28  Jim Meyering  <address@hidden>

        Fix syntax errors in autoconf.texi.
diff --git a/lib/autotest/general.m4 b/lib/autotest/general.m4
index ce65397..6280dac 100644
--- a/lib/autotest/general.m4
+++ b/lib/autotest/general.m4
@@ -667,16 +667,17 @@ Usage: $[0] [[OPTION]... [VARIABLE=VALUE]... [TESTS]]
 Run all the tests, or the selected TESTS, given by numeric ranges, and
 save a detailed log file.  Upon failure, create debugging scripts.

-You should not change environment variables unless explicitly passed
-as command line arguments.  Set \`AUTOTEST_PATH' to select the executables
+Do not change environment variables directly.  Instead, set them via
+command line arguments.  Set \`AUTOTEST_PATH' to select the executables
 to exercise.  Each relative directory is expanded as build and source
-directories relatively to the top level of this distribution.  E.g.,
+directories relative to the top level of this distribution.  E.g.,
+invoking this from within build directory, /tmp/foo-1.0:

   $ $[0] AUTOTEST_PATH=bin

-possibly amounts into
+is equivalent to the following, assuming the source directory is /src/foo-1.0:

-  PATH=/tmp/foo-1.0/bin:/src/foo-1.0/bin:\$PATH
+  PATH=/tmp/foo-1.0/bin:/src/foo-1.0/bin:\$PATH $[0]
 _ATEOF
 m4_divert_pop([HELP])dnl
 m4_divert_push([HELP_MODES])dnl
--
1.6.3.2.277.gd10543




reply via email to

[Prev in Thread] Current Thread [Next in Thread]