[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Move atlocal code to configure
From: |
Eric Blake |
Subject: |
Re: [PATCH] Move atlocal code to configure |
Date: |
Mon, 13 Jul 2009 05:19:37 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.22) Gecko/20090605 Thunderbird/2.0.0.22 Mnenhy/0.7.6.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Paolo Bonzini on 7/12/2009 5:09 AM:
> +for c in '\\' '"' '<' '>' '*' '?' '|'
Do you really want '\\', or just '\'? Then again, the old code used '\\',
and it helps balance font-lock; I don't think it harms anything.
> +do
> + touch "t${c}t" 2>/dev/null
Since we're moving this to a configure test, should we use the conftest
namespace?
> +AC_CACHE_CHECK([whether directories can have trailing spaces],
> + [ac_cv_dir_trailing_space],
> +[rm -rf 'tdir ' && mkdir 'tdir ' && touch 'tdir /tfile' 2>/dev/null
> +a=$?
Let's give this variable a longer name (there are only so many one-letter
variables, and they don't convey much meaning).
Other than that, I like the idea, so feel free to commit when you've
touched it up.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkpbGEkACgkQ84KuGfSFAYCF3QCfZO7z6ghjDP//rs9Ma1qlbUno
HDUAoIoc5vVznmKEDQyU3JllKdKbMgHk
=v0rG
-----END PGP SIGNATURE-----