Re: patch to add AT_CHECK_EUNIT autotest macro

[Paolo Bonzini]

I squashed in the attached patch, and I'm going to push it after you 
confirm that make check still passes with Erlang installed.  distcheck 
is still running.

In particular, I made the testsuite run also if Erlang is not found, to
check that it skips the test.

I also removed your attribution in specific.m4 on the grounds that it is 
probably going to grow (I may do JUnit) and that you already have it in 
lib/autoconf/erlang.m4. :-)

> > Can we make this code addition conditional to test suites in which
> > AT_CHECK_EUNIT is used?  (Diversions ought to help here.)
> > We don't want unnecessary code expansions.
>
> I don't see how to do that easily, since AT_CONFIG_TESTDIR doesn't parse the
> test suite at all.

I did that, conditional on the definition of AC_ERLANG_PATH_ERL.

> > > +AT_CHECK(["$ERLC" $ERLCFLAGS -b beam $1.erl])
> > Does that never produce any output?  Wow.
>
> If compilation is fine, no output is produced. But it outputs something in
> case of warnings or errors, which in this case indicates that the test-spec
> has an invalid syntax, which should fail the test. I think that this is a
> legitimate use of AT_CHECK?

Yes, it's okay.

Paolo

autoconf-erlang-p2.patch
Description: Text document