Re: patch to add AT_CHECK_EUNIT autotest macro

[Romain Lenglet]

On Sunday 02 August 2009 02:44:47 Paolo Bonzini wrote:
> I squashed in the attached patch, and I'm going to push it after you
> confirm that make check still passes with Erlang installed.  distcheck
> is still running.
>
> In particular, I made the testsuite run also if Erlang is not found, to
> check that it skips the test.

The test in autotest.at is much better, thanks!

I tested 2 cases:
- Erlang and EUnit found;
- Erlang detected, EUnit not found.

I changed two things to make them work:
- when the test is successful, suite.log doesn't contain '0.*skipped';
- the test code (testme_tests.erl) requires EUnit as well as Erlang to 
compile, as it uses an include file from EUnit.

> I also removed your attribution in specific.m4 on the grounds that it is
> probably going to grow (I may do JUnit) and that you already have it in
> lib/autoconf/erlang.m4. :-)

OK, no problem. :-)

> >> Can we make this code addition conditional to test suites in which
> >> AT_CHECK_EUNIT is used?  (Diversions ought to help here.)
> >> We don't want unnecessary code expansions.
[...]
> I did that, conditional on the definition of AC_ERLANG_PATH_ERL.

That looks good, but only ERL should be conditional to AC_ERLANG_PATH_ERL, and 
ERLC and ERLCFLAGS should be conditional to AC_ERLANG_PATH_ERLC.

Fixed in the attached patch.

Thanks!
--
Romain Lenglet

0001-Make-ERLC-and-ERLCFLAGS-def-in-atconfig-conditional-.patch
Description: Text Data