autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: AC_CHECK_HEADER


From: Paolo Bonzini
Subject: Re: AC_CHECK_HEADER
Date: Wed, 05 Aug 2009 01:23:08 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2


Well, warnings are to show that something is wrong, and protecting
includes with #error is right, at least in FreeBSD realm. Perhaps it's
not a bad idea to use AC_INCLUDE_DEFAULTS or some other mechanism when
checking a header with preprocessor (at least on FreeBSD).

I think that if the presence check makes no sense for this header, the four-argument version with AC_INCLUDES_DEFAULT should be used always.

OK, now to the patch:

1. It changes word "preprocessor" for "compiler" in AC_CHECK_HEADER
comment.

Fine.

2. places AC_PREPROC_IFELSE before AC_COMPILE_IFELSE in
_AC_CHECK_HEADER_MONGREL_BODY

I would like the maintainers of Autoconf to come back from holiday and comment on this one.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]