autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: unoptimized autoconf generated code


From: Ralf Wildenhues
Subject: Re: unoptimized autoconf generated code
Date: Wed, 3 Mar 2010 06:53:51 +0100
User-agent: Mutt/1.5.20 (2009-10-28)

* Eric Blake wrote on Tue, Mar 02, 2010 at 11:42:03PM CET:
> According to Ralf Wildenhues on 3/2/2010 2:45 PM:
> >   header="sys/some file.h"
> >   AS_TR_SH([HAVE_$header])=yes
> >   if test "x$HAVE_sys_some_file_h" = xyes; then echo "Have it!"; fi
> > 
> > which has been broken presumably by one of the earlier AS_LITERAL_IF
> > changes already.  (This is not a recent regression, so feel free to
> > ignore right now.)
> 
> Actually, it's a doc bug.  This is not valid shell variable assignment:
> 
> `echo $foo`=yes
> 
> So this patch is going in now, while I spend more time fixing the actual
> code changes.

Thanks.  Sticking an eval in front of any AS_TR_SH is going to be pretty
fragile though, and I'm not really sure whether, at the time this
example was added, the eval wasn't part of the AS_TR_SH expansion.

Speaking of which, one of my plans for less regressions is to continue
the "all documentation needs coverage" idea and to try to let each
nontrivial code snippet in the manual be used in the testsuite as-is,
just like the caching patch.

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]