[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Coverage for Fortran compiler macros.
From: |
Eric Blake |
Subject: |
Re: Coverage for Fortran compiler macros. |
Date: |
Fri, 02 Jul 2010 13:49:27 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.2 Thunderbird/3.0.5 |
On 06/28/2010 04:15 PM, Ralf Wildenhues wrote:
>>> This patch is a test balloon really. So far tested with GCC and one
>>> Intel version on GNU/Linux, and Sun suite on Solaris. It would need
>>> lots more testing, but I don't have access to many Fortran compilers.
>>> I wouldn't be surprised to see a fair amount of failures with them,
>>> consider yourself warned.
>>
>> I'm okay with releasing 2.66 in order to widen the feedback path of more
>> Fortran setups - we can deal with failures as they are reported (this
>> change isn't adding regressions, just exposing any long-time issues).
>> So yes, please apply. And thanks for the effort, since I am rather
>> illiterate at the moment when it comes to Fortran.
> With the patch below, I've tested some version of GNU, Sun, IBM XL, and
> Intel on at least one system each. I consider that fairly encouraging.
> The other compilers' flags are taken from documentation only.
>
> OTOH, I'd love to hear from Fortran experts about a better tests that
> fails free-form-assuming compilers. The comment seems to work with all
> compilers tested, but I'm not sure that's a given.
Well, I've gone ahead and applied your patch, and hope to get 2.66 out
the door real soon now to widen the coverage.
> New macro AC_FC_FIXEDFORM, improved AC_FC_FREEFORM, coverage.
>
> * lib/autoconf/fortran.m4 (_AC_FC_DIALECT_YEAR): Fix typo in
> comment.
> (AC_FC_FREEFORM): Update list of known options for Sun, HP,
> Lahey/Fujitsu Fortran compilers. Use M4 quoting consistently.
> (AC_FC_FIXEDFORM): New macro.
> * tests/fortran.at (AC_FC_DUMMY_MAIN usage, AC_FC_MAIN usage):
> Use AC_FC_FIXEDFORM, to avoid testsuite failure with FC=xlf95.
> (AC_FC_FREEFORM with AC_FC_SRCEXT, AC_FC_FIXEDFORM)
> (AC_FC_FIXEDFORM with AC_FC_SRCEXT): New tests.
> * tests/mktests.sh: No need to exclude AC_FC_FREEFORM, it uses
> AC_LANG_PUSH/AC_LANG_POP.
> * doc/autoconf.texi (Fortran Compiler): Document it.
> * NEWS: Update.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: Coverage for Fortran compiler macros.,
Eric Blake <=