autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Another empty argument through expr workaround.


From: Eric Blake
Subject: [PATCH] Another empty argument through expr workaround.
Date: Tue, 20 Jul 2010 08:11:04 -0600

* lib/autoconf/status.m4 (_AC_OUTPUT_CONFIG_STATUS): Detect empty
arguments.

Signed-off-by: Eric Blake <address@hidden>
---

> This patch aims to fix the both instances I found at a glance.  I'm
> running out of time for adding tests or verifying that
> maintainer-check-posix already exposes the issues, or that there are no
> further issues; sorry.

I found only one more issue using:
git grep '\*='
but like you, don't know if I missed things that didn't fit that pattern.

Hmm - I should try to update the testsuite before pushing this...

 ChangeLog              |    4 ++++
 lib/autoconf/status.m4 |    5 +++++
 2 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index bd7c15f..cb3f858 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2010-07-20  Eric Blake  <address@hidden>

+       Another empty argument through expr workaround.
+       * lib/autoconf/status.m4 (_AC_OUTPUT_CONFIG_STATUS): Detect empty
+       arguments.
+
        Also reject ' and newline from AC_INIT strings.
        * lib/autoconf/general.m4 (_AC_INIT_LITERAL): Reject a couple more
        problematic characters.
diff --git a/lib/autoconf/status.m4 b/lib/autoconf/status.m4
index b9e7026..57b6ace 100644
--- a/lib/autoconf/status.m4
+++ b/lib/autoconf/status.m4
@@ -1464,6 +1464,11 @@ ac_need_defaults=:
 while test $[#] != 0
 do
   case $[1] in
+  --*=)
+    ac_option=`expr "X$[1]" : 'X\([[^=]]*\)='`
+    ac_optarg=
+    ac_shift=:
+    ;;
   --*=*)
     ac_option=`expr "X$[1]" : 'X\([[^=]]*\)='`
     ac_optarg=`expr "X$[1]" : 'X[[^=]]*=\(.*\)'`
-- 
1.7.1.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]