[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Close job control fd before running tests.
|
From: |
Ralf Wildenhues |
|
Subject: |
Re: [PATCH] Close job control fd before running tests. |
|
Date: |
Wed, 21 Jul 2010 06:42:40 +0200 |
|
User-agent: |
Mutt/1.5.20 (2010-04-22) |
* Ralf Wildenhues wrote on Wed, Jul 21, 2010 at 06:29:31AM CEST:
> * Ralf Wildenhues wrote on Wed, Jul 21, 2010 at 06:24:04AM CEST:
> > > +Fortunately, an attempt to close an already closed file descriptor will
> > > +portably succeed.
> >
> > This is not true. ksh93, for example, will happily fail to close a
> > closed fd. You need to try in non-interactive mode.
>
> Hmm, maybe I was confused in testing this. Nonetheless, the at_first
> issue in my patch is still an improvement, and your patch should also
> close all fds for the first worker thread, I guess.
OK, nevermind, I was just totally confused. Haven't had coffee yet.
Sorry about that.
Ralf