[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Minor testsuite size reduction.

From: Eric Blake
Subject: Re: [PATCH] Minor testsuite size reduction.
Date: Wed, 21 Jul 2010 12:26:10 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.0.5

On 07/21/2010 11:54 AM, Ralf Wildenhues wrote:
> * Eric Blake wrote on Wed, Jul 21, 2010 at 03:58:16PM CEST:
>> * lib/autotest/general.m4 (AT_INIT) <serial testing>: Ensure
>> at_jobs is 1.
>> @@ -1440,6 +1458,7 @@ dnl        kill -13 $$
>>    wait
>>  else
>>    # Run serially, avoid forks and other potential surprises.
>> +  at_jobs=1
>>    for at_group in $at_groups; do
>>      at_fn_group_prepare
>>      if cd "$at_group_dir" &&
> Rereading this again, it wasn't right, though, or, put another way, I
> think it causes potentially worse behavior in an unusual setting (not
> verified):
> Say you run './testsuite -jN' on a system without mkfifo, then at_quiet
> gets set to : but above change later sets at_jobs to 1, causing
> $at_desc_line to never be printed.
> Sorry about leading you down there,

Is this something we need to revert before 2.67 (seeing as how I've been
unable to upload yet, I could rebase it in)?

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]