[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Minor testsuite size reduction.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] Minor testsuite size reduction. |
Date: |
Thu, 22 Jul 2010 20:26:08 +0200 |
User-agent: |
Mutt/1.5.20 (2010-04-22) |
* Ralf Wildenhues wrote on Wed, Jul 21, 2010 at 08:58:06PM CEST:
> * Eric Blake wrote on Wed, Jul 21, 2010 at 08:26:10PM CEST:
> > On 07/21/2010 11:54 AM, Ralf Wildenhues wrote:
> > > * Eric Blake wrote on Wed, Jul 21, 2010 at 03:58:16PM CEST:
> > >> # Run serially, avoid forks and other potential surprises.
> > >> + at_jobs=1
> > > Rereading this again, it wasn't right, though, or, put another way, I
> > > think it causes potentially worse behavior in an unusual setting (not
> > > verified):
> > >
> > > Say you run './testsuite -jN' on a system without mkfifo, then at_quiet
> > > gets set to : but above change later sets at_jobs to 1, causing
> > > $at_desc_line to never be printed.
> > Is this something we need to revert before 2.67 (seeing as how I've been
> > unable to upload yet, I could rebase it in)?
>
> Well, if, then you could revert just this one line. It's not a huge
> issue, but the change didn't fix a regression, so reverting should be
> safe.
I now verified that your reversion of this really did avoid a regression
in the case I outlined before. So thanks again.
Cheers,
Ralf