autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Keep testsuite files on unexpected pass.


From: Eric Blake
Subject: Re: [PATCH] Keep testsuite files on unexpected pass.
Date: Sat, 14 Aug 2010 12:06:18 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.1.1

On 08/14/2010 12:55 AM, Ralf Wildenhues wrote:
> * Peter Rosin wrote on Tue, Aug 10, 2010 at 11:08:03PM CEST:
>> Subject: [PATCH] Keep testsuite files on unexpected pass.
>>
>> * lib/autotest/general.m4 (AT_INIT) <at_fn_group_postprocess>:
>> Don't cleanup the group directory when a test unexpectedly passes.
>> * tests/autotest.at (Cleanup): Check that an unexpected pass leaves
>> the test group directory intact.
> 
> For what it's worth, this patch looks good to me.  The "Cleanup" test
> group might be a bit more complex than needed, but that's not new with
> your patch.

Agreed; and applied.

> 
> Also I just noticed that --errexit is broken wrt. XPASS tests, but
> that's not new with your patch either.  The following seems to fix
> it but I don't have testsuite exposure yet.  One thing to note for
> the latter is that the "test ... and inhibited subsequent tests."
> notice is not necessarily true, in that the testsuite does run
> subsequent tests after an XPASS.

Good catch.  Are you planning on cleaning up this diff into a full
patch, or should I apply it as is?

> @@ -1244,6 +1244,9 @@ _ATEOF
>        # or the success was unexpected.
>        if $at_debug_p || test $at_res = xpass; then
>       at_fn_create_debugging_script
> +     if test $at_res = xpass && $at_errexit; then
> +       echo stop > "$at_stop_file"
> +     fi
>        else
>       if test -d "$at_group_dir"; then
>         find "$at_group_dir" -type d ! -perm -700 -exec chmod u+rwx \{\} \;
> 
> 

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]