[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] autotest: work around zsh bug

From: Paolo Bonzini
Subject: Re: [PATCH] autotest: work around zsh bug
Date: Tue, 14 Sep 2010 15:35:48 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.0.5

On 09/13/2010 07:38 PM, Eric Blake wrote:
* lib/autotest/general.m4 (AT_DATA): Special case an empty data
file, since zsh botches empty here-docs.
* doc/autoconf.texi (Writing Testsuites)<AT_DATA>: Document that
empty contents is allowed.
* tests/ (AT_DATA): New test.
Reported by Ralf Wildenhues.

Signed-off-by: Eric Blake<address@hidden>

Independent of the doc patch about the zsh bug, it turned out
to be pretty easy to work around it in AT_DATA.

By testing the tests/ change independently from the rest of the
patch, I've confirmed that bash passes both before and after, while
zsh fails before but passes after the rest of the patch.

This does not protect against:
AT_DATA([file], [macro_that_expands_to_nothing])
but I suspect that is enough of a corner case to not worry about
unless we get a specific report of someone needing it.

What about moving AT_DATA to m4sh?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]