[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Overriding LN_S

From: Ralf Wildenhues
Subject: Re: Overriding LN_S
Date: Fri, 15 Oct 2010 19:51:55 +0200
User-agent: Mutt/1.5.20 (2010-08-04)

Hi Peter,

* Peter Rosin wrote on Fri, Oct 15, 2010 at 09:28:53AM CEST:
> I haven't actually tested the patch, but it seems trivial enough.

Bzzt.  You are just barely saved yourself by admitting it upfront!  ;->

> --- a/lib/m4sugar/m4sh.m4
> +++ b/lib/m4sugar/m4sh.m4

>  else
> -  as_ln_s='cp -p'
> -fi
> -rm -f conf$$ conf$$.exe conf$$.dir/conf$$.file conf$$.file
> -rmdir conf$$.dir 2>/dev/null
> +  as_ln_s=$LN_S
> +endif

Shell if ends with fi, not endif.


With that fixed, I ran the testsuite on GNU/Linux once without LN_S set,
once with export LN_S='cp -p', both successfully, but with LN_S=bla, the
only failure is from the test, because libtoolize
honors $LN_S.

I think a testsuite addition that ensures that LN_S is honored for both
AC_PROG_LN_S and for AS_LN_S is in order; we have already regressed on
this once, a few years ago.  Please ping me if you want me to write one.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]