[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [FYI] docs: cygnus mode doesn't require AM_CYGWIN32 macro.

From: Eric Blake
Subject: Re: [FYI] docs: cygnus mode doesn't require AM_CYGWIN32 macro.
Date: Mon, 10 Jan 2011 08:33:28 -0700
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7

On 01/09/2011 02:19 AM, Ralf Wildenhues wrote:
> [ replacing automake-patches with autoconf-patches ]
> tying up another loose end:
> * Ralf Wildenhues wrote on Wed, Dec 22, 2010 at 07:22:24AM CET:
>> Hmpf.  Nowadays AM_CYGWIN just expands to AC_CYGWIN, which causes
>> $CYGWIN to be set.  The latter is probably a bad idea for other reasons
>> (Cygwin AFAIK uses the variable for other purposes), but at least one
>> macro in Autoconf's fortran.m4 still seems to make use of $CYGWIN.  It
>> should at least also be fixed to use $host_os instead.
> The patch below should address that.  I have no idea whether this code
> is still relevant on Cygwin, but I'm assuming that it is.  I haven't
> actually tested it there, but I'm running the testsuite on GNU/Linux
> right now to ensure there are no undesired side effects.  OK to push
> when that passes?

Yes, please push.  $CYGWIN should never be modified during a configure
script on Cygwin, so checking $host_os is indeed better.

>     Avoid reference to $CYGWIN in Fortran macros.
>     * lib/autoconf/fortran.m4 (_AC_FC_LIBRARY_LDFLAGS): Require
>     AC_CANONICAL_HOST.  Replace test for $CYGWIN with $host_s test.

I'll fire up a full testsuite run on cygwin later, and in the unlikely
event of a regression, I'll report back; it just that it takes several
hours to run a full testsuite.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]