[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: AC_FC_CHECK_BOUNDS for Fortran array bounds checking.

From: Eric Blake
Subject: Re: AC_FC_CHECK_BOUNDS for Fortran array bounds checking.
Date: Tue, 01 Mar 2011 12:53:02 -0700
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7

On 02/27/2011 09:10 AM, Ralf Wildenhues wrote:
> [ moving from autoconf@ to -patches@ ]
> Hello,
> here's a first macro to improve Fortran support in Autoconf.
> It uses Fortran 90 interface declarations, so a F77 version
> would have to be different (and I'm not quite sure whether
> this works as well in Fortran 77).  I only have access to a
> few of the listed compilers, the other flags are taken from
> manuals only.  I gather fixes will come from users over time.
> OK to push?  Eve-Marie, OK to add your name and email to THANKS?

OK from my end, after addressing a nit.  In fact, since you are much
more familiar with Fortran than I am, I'm comfortable with you pushing
all of your recent Fortran patches if you don't get any better review
within a few days.

> +++ b/doc/autoconf.texi
> @@ -8246,6 +8246,16 @@ Fortran Compiler
>  message).
>  @end defmac
> address@hidden AC_FC_CHECK_BOUNDS (@ovar{action-if-success}, 
> @ovar{action-if-failure})

Should this be listed as @dvar{action-if-failure, AC_MSG_FAILURE}...

> address@hidden
> +
> +The @code{AC_FC_CHECK_BOUNDS} macro tries to enable array bounds checking
> +in the Fortran compiler.  If successful, the @var{action-if-success}
> +is called and any needed flags are added to @code{FCFLAGS}.  Otherwise,
> address@hidden is called, which defaults to failing with an error
> +message.

...since it defaults in a fatal message?  Compare the recent patch to

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]