[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] AC_INIT: properly quote package name containing m4 macro

From: Ralf Corsepius
Subject: Re: [PATCH] AC_INIT: properly quote package name containing m4 macro
Date: Thu, 17 Mar 2011 17:32:38 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Thunderbird/3.1.7

On 03/17/2011 04:50 PM, Stefano Lattarini wrote:
Hi Eric, and thanks for having solved this.

I have just a minor nit and a question below (sorry for not giving a
proper review, but I must admit some parts of your patch are way beyond
me ATM :-(, especially the new definition of AC_PACKAGE_TARNAME).

On Thursday 17 March 2011, Eric Blake wrote:


Note that this is a subtle semantic change.  It used to be that you
could do:

m4_define([pkg_name], [foo])
AC_INIT([pkg_name], [1.0])

and that would result in AC_SUBST of PACKAGE_NAME=foo

With this patch, it results in PACKAGE_NAME=pkg_name.

I don't see too much harm in making this change,

I do - If I understand this correctly, you are breaking a common trick being used by "big packages". Mine are amongst those and IIRC and so are others.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]