autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/7] maint: placate syntax-check rules: exempt some false pos


From: Jim Meyering
Subject: Re: [PATCH 4/7] maint: placate syntax-check rules: exempt some false positives
Date: Sat, 21 Jan 2012 15:22:45 +0100

Eric Blake wrote:
> On 01/21/2012 04:14 AM, Jim Meyering wrote:
>> From: Jim Meyering <address@hidden>
>>
>
> No ChangeLog entry?

Added, now.

    * cfg.mk: Exempt maint.mk from the "undesirable word seq" check.
    Exempt maint.mk and autoconf.texi from the test_minus_ao check.

>> ---
>>  cfg.mk |    4 ++++
>>  1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/cfg.mk b/cfg.mk
>> index a66c247..5c2e5e5 100644
>> --- a/cfg.mk
>> +++ b/cfg.mk
>> @@ -116,3 +116,7 @@ update-copyright-env = \
>>
>>  # Prevent incorrect NEWS edits.
>>  old_NEWS_hash = 6a8aa950938fba063f3dc2b0e11e67e8
>> +
>> +exclude_file_name_regexp--sc_prohibit_undesirable_word_seq = ^maint\.mk$$
>> +exclude_file_name_regexp--sc_prohibit_test_minus_ao = \
>> +  ^(maint\.mk|doc/autoconf\.texi)$$
>
> Incomplete.  I'd rather see this patch nuke all of the .x-sc files and
> convert them into exclude_file_name_regexp entries.

That will be an improvement, but it does not belong in this series.
This series is addressing preexisting (and a few new, with sync)
syntax-check failures.  What you're proposing is most welcome (moving the
exemptions from numerous separate files into cfg.mk), but it qualifies
as a no-semantic-change and deserves to be separate.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]