[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] AC_CONFIG_MACRO_DIRS: new macro, mostly for aclocal
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH 1/2] AC_CONFIG_MACRO_DIRS: new macro, mostly for aclocal |
Date: |
Sat, 03 Nov 2012 01:31:43 +0100 |
On 11/02/2012 10:34 PM, Eric Blake wrote:
> On 11/02/2012 03:19 PM, Eric Blake wrote:
>>
>> I wrote these off the cuff while composing the email, so they are
>> relatively untested. And while re-reading, I see I botched the
>> self-redefinition, as well as failed to call AC_CONFIG_MACRO_DIR if the
>> first use was AC_CONFIG_MACRO_DIRS. Here's another attempt, again
>> relatively untested.
>
> Self-redefinition is a bit complex; how about this alternative?
>
> [SNIP]
>
I believe some of the enhancements proposed here are definitely valuable
(e.g., the warning against multiple AC_CONFIG_MACRO_DIR). But they
should be follow-up improvements over my patches, rather than squash-ins.
And they should have proper testsuite coverage too, IMNSHO.
Regards, and thanks,
Stefano
- Re: [PATCH 1/2] AC_CONFIG_MACRO_DIRS: new macro, mostly for aclocal, Eric Blake, 2012/11/02
- Re: [PATCH 1/2] AC_CONFIG_MACRO_DIRS: new macro, mostly for aclocal, Eric Blake, 2012/11/02
- Re: [PATCH 1/2] AC_CONFIG_MACRO_DIRS: new macro, mostly for aclocal, Stefano Lattarini, 2012/11/02
- Re: [PATCH 1/2] AC_CONFIG_MACRO_DIRS: new macro, mostly for aclocal, Adrian Bunk, 2012/11/09
- Re: [PATCH 1/2] AC_CONFIG_MACRO_DIRS: new macro, mostly for aclocal, Eric Blake, 2012/11/09
- Re: [PATCH 1/2] AC_CONFIG_MACRO_DIRS: new macro, mostly for aclocal, Nick Bowler, 2012/11/09
- aclocal: stop handling AC_CONFIG_MACRO_DIR; handle just AC_CONFIG_MACRO_DIRS (was: Re: [PATCH 1/2] AC_CONFIG_MACRO_DIRS: new macro, mostly for aclocal, Stefano Lattarini, 2012/11/09
- Re: bug#12845: aclocal: stop handling AC_CONFIG_MACRO_DIR; handle just AC_CONFIG_MACRO_DIRS, Stefano Lattarini, 2012/11/10