[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/3] Modernize header checks, v2

From: Zack Weinberg
Subject: Re: [PATCH 0/3] Modernize header checks, v2
Date: Sat, 07 Sep 2013 11:24:40 -0400
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:17.0) Gecko/20130801 Thunderbird/17.0.8

On 2013-09-07 10:06 AM, Paul Eggert wrote:
Zack Weinberg wrote:
One remaining wart is that autoupdate
replaces AC_HEADER_STDC with an overt invocation of
construct that didn't expose this internal macro but would still DTRT
both before and after an autoupdate run.  Ideas?

Perhaps we should make that macro public, under the name
to inject _AC_* stuff into user code.

I had a better idea this morning. The problem I was having is fundamentally the same problem as Ross was having with conditional AC_CHECK_HEADERS, so:

[# Autoupdate added the following line to ensure that your configure
# script's behavior did not change.  It is probably safe to remove.
AS_IF([:], [], [ac_dummy="AC_INCLUDES_DEFAULT"])

The complete testsuite is still running, but the specific check of AC_HEADER_STDC passed with this construct.

The other changes you're making all sound reasonable,
though I haven't reviewed the code.  Unless someone
objects soon I think they should be installed.  Would
you like to do that?  I see two Zack Weinbergs zackw
and zwol at Savannah, but neither have checkin rights,
so I'm not sure what's going on there.

'zackw' is my current Savannah account. If you give it checkin rights, I can land the patches. I would appreciate a detailed review if you have time, though; this is the first time I've attempted to make serious changes to Autoconf itself.

'zwol' is also a handle I use often; it's likely that I created that account some time ago and then lost the password.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]