[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/6] AC_CHECK_HEADER/AC_CHECK_HEADERS: complete transition to

From: Eric Blake
Subject: Re: [PATCH 2/6] AC_CHECK_HEADER/AC_CHECK_HEADERS: complete transition to compile tests.
Date: Sat, 21 Sep 2013 06:42:46 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

On 09/13/2013 06:42 PM, Zack Weinberg wrote:
> * lib/autoconf/headers.m4 (AC_CHECK_HEADER): Use _AC_CHECK_HEADER_COMPILE
>   by default.  Continue to use _AC_CHECK_HEADER_PREPROC if fourth arg is '-'.
>   (_AC_CHECK_HEADER_PREPROC): Issue a deprecation warning.
> * tests/, tests/ Update uses of AC_CHECK_HEADER(S).
> * doc/autoconf.texi, NEWS: Document change.
> Signed-off-by: Zack Weinberg <address@hidden>
> ---

> +#                       [ACTION-IF-FOUND], [ACTION-IF-NOT-FOUND])
> +# ------------------------------------------------------------------
> +# In case anyone used this undocumented macro.  Map to the _PREPROC
> +# semantics to minimize the chance of breaking anything.

Well, in 2.69, the mongrel code favored compile results, not preproc.
But as this is undocumented, and as the preproc variant outputs a
warning, the users deserve a warning for using undocumented macros.  I
agree with the decision.


Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]