[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/4] git-version-gen: remove cr as well

From: Eric Blake
Subject: Re: [PATCH 4/4] git-version-gen: remove cr as well
Date: Mon, 22 Sep 2014 09:22:07 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0

[adding gnulib]

On 09/22/2014 12:59 AM, KO Myung-Hun wrote:
> * build-aux/git-version-gen: Subject.
> ---
>  build-aux/git-version-gen |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> diff --git a/build-aux/git-version-gen b/build-aux/git-version-gen
> index 3468247..f04b31f 100755
> --- a/build-aux/git-version-gen
> +++ b/build-aux/git-version-gen
> @@ -126,6 +126,7 @@ fi
>  tag_sed_script="${tag_sed_script:-s/x/x/}"
> +cr='
> '

Sadly, this won't work.  There's no easily portable way to specify a raw
carriage return in scripting; it's possible to use (some versions of) tr
to remove it (finding the right working tr on Solaris is a pain,
though); and if you can guarantee a particular system such as mingw
where certain GNU tools are known to exist you can rely on those
extensions.  But in the long run, this problem needs to be fixed
upstream in gnulib (autoconf just copies the script verbatim from
gnulib), and in a way that doesn't use a raw CR in the file.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]