[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] AC_C_BIGENDIAN: fix narrowing error

From: Eric Blake
Subject: Re: [PATCH] AC_C_BIGENDIAN: fix narrowing error
Date: Mon, 12 Mar 2018 07:59:17 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/12/2018 07:47 AM, Eric Blake wrote:
On 03/12/2018 04:24 AM, Rechi wrote:
The following patch will fix AC_C_BIGENDIAN, for cross compiling, if narrowing is a fatal error in the used compiler.

Narrowing should not be a fatal error unless you used -Werror, which we advise against doing (it is impossible in general to write all configure snippets to be warning-proof against all possible -Werror settings).

Clarification: we recommend against including -Werror in CFLAGS during configure. It's just fine to have a dedicated configure probe for whether -Werror works, and then adding -Werror to CFLAGS during make time. It's just configure time where using -Werror globally is unsupported.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization: |

reply via email to

[Prev in Thread] Current Thread [Next in Thread]