autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] specify void prototype for functions with no parameters


From: Paul Eggert
Subject: Re: [PATCH v2] specify void prototype for functions with no parameters
Date: Tue, 30 Aug 2022 16:53:51 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 8/29/22 21:35, Khem Raj wrote:
Compilers defaulting to C99 flag such functions as warning which fails
to compile when using -Werror

As mentioned earlier, projects should not use -Werror when configuring, for several reasons (this is just one). After you mentioned rsync was using something like -Werror I sent in a patch to the rsync folks, and rsync has been fixed:

https://github.com/WayneD/rsync/commit/9a3449a3980421f84ac55498ba565bc112b20d6c

What other projects are doing it? They should be fixed too, regardless of whether we change Autoconf here.

As for Autoconf, if we're going to make this change at all, we should do it fully. Something like the attached patch, perhaps. I haven't installed it.

Attachment: 0001-Port-to-compilers-that-moan-about-K-R-func-decls.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]