[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] specify void prototype for functions with no parameters
|
From: |
Zack Weinberg |
|
Subject: |
Re: [PATCH v2] specify void prototype for functions with no parameters |
|
Date: |
Fri, 02 Sep 2022 11:42:35 -0400 |
|
User-agent: |
Cyrus-JMAP/3.7.0-alpha0-841-g7899e99a45-fm-20220811.002-g7899e99a |
On Thu, Sep 1, 2022, at 7:18 PM, Paul Eggert wrote:
> Thanks for checking. How about the attached patch instead? It's closer
> to what you originally suggested.
>
> Zack, any thoughts on this sort of thing?
...
> --- a/doc/autoconf.texi
> +++ b/doc/autoconf.texi
> @@ -5460,9 +5460,8 @@ the @samp{#undef malloc}):
> #include <config.h>
> #undef malloc
>
> -#include <sys/types.h>
> -
> -void *malloc ();
> +#include <stdlib.h>
> +#undef malloc
Why the #undef malloc here? If I understand what this is doing
correctly, it should be sufficient to #undef malloc after including
config.h (and this is already in place, a few lines above what you
changed).
Otherwise looks good to me.
zw