Re: usage of ac_check_header

[Benoit SIGOURE]

On Jul 24, 2007, at 12:00 PM, Joao Miguel Ferreira wrote:

> On Tue, 2007-07-24 at 00:25 +0200, Ralf Wildenhues wrote:
> > Hello Joao,
>
> Hi Ralph,
>
> > a small side point regarding M4 quotation: instead of
> >
> > * Joao Miguel Ferreira wrote on Mon, Jul 23, 2007 at 10:18:08PM CEST:
> > > AC_CHECK_HEADER(xpath.h,,AC_MSG_ERROR([cannot find headers for  
> > > libxml2]))
> >
> > it's better to write this:
> >
> > AC_CHECK_HEADER(xpath.h,,[AC_MSG_ERROR([cannot find headers for  
> > libxml2])])
>
> Is this something I could/should do globally ???

Yes.  Unless you have a good reason, quote all your macro arguments.

> for example, I also have these:
>
> - AC_CHECK_HEADERS(unistd.h sys/socket.h)
> - AC_CHECK_FUNCS(socket htons)
> - AC_CHECK_LIB(xml2,xmlParseDoc,,AC_MSG_ERROR([cannot link to  
> libxml2]))

Yep, throw some [] in there:
- AC_CHECK_HEADERS([unistd.h sys/socket.h])
- AC_CHECK_FUNCS([socket htons])
- AC_CHECK_LIB([xml2], [xmlParseDoc], [], [AC_MSG_ERROR([cannot link  
to libxml2])])

> could/should I quote it all ? I'm quite used to quoting in Perl... is
> this somewhat similar ?

Hmm... not quite.  I suggest you have a look at:
http://www-src.lip6.fr/homepages/Alexandre.Duret-Lutz/dl/autotools.pdf
M4 quoting is explained from slide 57 to 62.  It's worth reading.   
Just like the rest of this tutorial by the way.

--
Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory

PGP.sig
Description: This is a digitally signed message part