Re: Quick divert() 2.13/2.6x portability macro

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Rasmus Lerdorf on 11/28/2009 6:42 AM:
> Basically the diversions are there to organize the phases of the checks.
>  From
> http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/configure.in?view=markup
> 
> ## Diversion 1 is the autoconf + automake setup phase. We also
> ## set the PHP version, deal with platform-specific compile
> ## options and check for the basic compile tools.

Here's a thought.  I'm not sure whether the divert's were necessary in
autoconf 2.13 (that is so old that it pre-dates my involvement with
autoconf, and I have no interest in trying to make it work).  But, on the
premise that they were needed back then, but are causing problems now, why
not just:

AC_DEFUN([PHP_DIVERT],[
   ifdef([AC_AUTOCONF_VERSION], [],
     [
       divert($1)
     ])
])

that is, only use the divert for the autoconf version that required the
divert.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAksRP1MACgkQ84KuGfSFAYCuqwCeKvLriJcUOso4GFVhNMO9BJYf
xBAAoNaeyIIGrmw/Y1+fxOCiQIfraCbP
=fVgb
-----END PGP SIGNATURE-----