Re: [PATCH] C++11 keyword fallback

[Roger Leigh]

On Sun, Feb 03, 2013 at 01:52:18PM +0900, Miles Bader wrote:
> Roger Leigh <address@hidden> writes:
> > The attached patch introduces three macros:
> >   AC_CXX_CONSTEXPR
> >   AC_CXX_FINAL
> >   AC_CXX_NULLPTR
> > which behave like AC_C_CONST et al but are for the new
> > C++11 constextr, final and nullptr keywords.
> 
> All of these seem a bit questionable...
> I think the common thread here is that even when C++ programs are
> written with certain constraints in mind (e.g. "don't use final") in
> order to cooperate with their autoconf-iscation, they almost always
> use external header files which they _don't_ control.
> 
> As such, maybe autoconf macros that explicitly took an identifier to
> define would be safer.
> 
> E.g., "AC_CXX_FINAL([MY_PACKAGE_FINAL])" would define
> "MY_PACKAGE_FINAL" to either be "final" or "".  The package my-package
> could then safely use MY_PACKAGE_FINAL with this autoconf-iscation in
> mind, without worrying about conflicts with external headers.

If you feel that this would be generally useful, I'll be happy to
update the patch to do this.  OTOH, if they all introduce extra
complications WRT replacement of non-keyword names as you mention
with "final", maybe this is best to leave until there's a demand
for such headers.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux    http://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-    GPG Public Key      F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800