[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Wrong order of preprocessor and compiler flags
From: |
Sam James |
Subject: |
Re: Wrong order of preprocessor and compiler flags |
Date: |
Thu, 24 Mar 2022 15:41:04 +0000 |
> On 24 Mar 2022, at 14:42, Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
> wrote:
>
> On Thu, 24 Mar 2022, Evgeny Grin wrote:
>>
>> It's not uncommon to use CFLAGS for macros or for '-I' flags.
>> I think it's easy to imagine other conflicting situation where the order of
>> used flags is significant.
>
> It may not be uncommon, but it is a usage bug to use CFLAGS for pre-processor
> options. Such usages should be corrected.
>
> Becides cases where the pre-processor may be used directly (not sure if there
> are any), it should be considered that CPPFLAGS works for both the C and C++
> compilers but CFLAGS is only for the C compiler.
>
>> Usage of CPPFLAGS before CFLAGS looks logical for me, I think autoconf
>> should be fixed.
>
> It does feel more logical.
>
Agreed on both counts & with the original post. We handle stuff like this quite
often downstream and would be glad to see this.
best,
sam
signature.asc
Description: Message signed with OpenPGP