automake-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[automake-commit] branch master updated: distdir/emacs: avoid `test -d`


From: Mike Frysinger
Subject: [automake-commit] branch master updated: distdir/emacs: avoid `test -d` with MKDIR_P
Date: Sat, 14 Jan 2023 19:23:32 -0500

This is an automated email from the git hooks/post-receive script.

vapier pushed a commit to branch master
in repository automake.

View the commit online:
https://git.savannah.gnu.org/gitweb/?p=automake.git;a=commitdiff;h=7fd1d064a545cfb7864d97694ae98e3d060c62d3

The following commit(s) were added to refs/heads/master by this push:
     new 7fd1d064a distdir/emacs: avoid `test -d` with MKDIR_P
7fd1d064a is described below

commit 7fd1d064a545cfb7864d97694ae98e3d060c62d3
Author: Mike Frysinger <vapier@gentoo.org>
AuthorDate: Fri Jan 13 04:02:57 2023 -0500

    distdir/emacs: avoid `test -d` with MKDIR_P
    
    We don't need to do the `test -d ... || mkdir ...` dance when we
    have the MKDIR_P helper, so simplify this code a bit.
    
    * lib/am/distdir.am: Use $(MKDIR_P).
    * lib/am/lisp.am: Drop redundant `test -d`.
---
 lib/am/distdir.am | 2 +-
 lib/am/lisp.am    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/am/distdir.am b/lib/am/distdir.am
index 4cfc742ce..264713c33 100644
--- a/lib/am/distdir.am
+++ b/lib/am/distdir.am
@@ -103,7 +103,7 @@ endif %?TOPDIR_P%
 ##
 if %?TOPDIR_P%
        $(am__remove_distdir)
-       test -d "$(distdir)" || mkdir "$(distdir)"
+       $(AM_V_at)$(MKDIR_P) "$(distdir)"
 endif %?TOPDIR_P%
 ##
 ##
diff --git a/lib/am/lisp.am b/lib/am/lisp.am
index d5858f866..c96be2121 100644
--- a/lib/am/lisp.am
+++ b/lib/am/lisp.am
@@ -37,7 +37,7 @@ endif %?INSTALL%
            am__subdir_includes="-L $$am__dir -L $(srcdir)/$$am__dir"; \
          esac; \
 ## Emacs byte-compilation won't create this automatically, sadly.
-         test -d "$$am__dir" || $(MKDIR_P) "$$am__dir" || exit 1; \
+         $(MKDIR_P) "$$am__dir" || exit 1; \
          $(EMACS) --batch --no-site-file \
            $(AM_ELCFLAGS) $(ELCFLAGS) \
            $$am__subdir_includes -L $(builddir) -L $(srcdir) \



reply via email to

[Prev in Thread] Current Thread [Next in Thread]