automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI: catch variable names starting with `_' (PR/291).


From: Akim Demaille
Subject: Re: FYI: catch variable names starting with `_' (PR/291).
Date: 09 Jul 2002 09:23:43 +0200
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Honest Recruiter)

| Strictly speaking, the _am_installdirs variable doesn't need to
| be renamed because it's never output, but it seems cleaner to
| keeps things simple and apply to same rule to everybody.  (BTW,
| reading the code I've not found where this variable is stopped
| from being output; 

It used to be related to += which meant you'd have to wait for the
output sign.

| there are a two `Accumulating variables must
| not be output' comments, but they seem misplaced.)

That's probably history now, but `accumulating' referred to +=.  
Honestly, I fail to see to why these comments are there.


| @@ -5927,8 +5927,13 @@
|  {
|    my ($var, $var_is_am, $type, $cond, $value, $where) = @_;
|  
| -  err $where, "bad characters in macro name `$var'"
| +  err $where, "bad characters in variable name `$var'"
|      if $var !~ /$MACRO_PATTERN/o;

In Make talk, these are really macros.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]