automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: mkinstalldirs: directory names with embedded whitespace or newlines


From: Stepan Kasal
Subject: Re: mkinstalldirs: directory names with embedded whitespace or newlines
Date: Thu, 30 Jun 2005 14:21:37 +0200
User-agent: Mutt/1.4.1i

Hello,

On Wed, Jun 29, 2005 at 11:04:25PM +0200, Alexandre Duret-Lutz wrote:
> I'm installing this on HEAD and branch-1-9.

thanks.

Some nit picking:

> +case "$*" in
> +  *-p*) exit 1;;
> +esac

There is no word-splitting of the argument of "case", so you don't
have to quote $*.

> +export PATH

There is no need to call export again, you have already exported it
in the outer shell.

Of course, none of these changes is necessary; it's just a matter
of your taste.

Anyway, a patch is attached.

Stepan

Attachment: automake-20050630-mkinst3.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]