Re: AM_OUTPUT_DEPENDENCY_COMMANDS problem

[Eric Blake]

Duft Markus <Markus.Duft <at> salomon.at> writes:

> [test x"$AMDEP_TRUE" != x"" || _AM_OUTPUT_DEPENDENCY_COMMANDS]
> 
> I created a small patch fixing the problem, by making the whole
> _AM_OUTPUT_DEPENDENCY_COMMANDS being affected by the '||'. I've attached
> it.

Thanks for the diagnosis; it looks correct that we need to add {} somewhere.  
However, wouldn't it be better to rewrite _AM_OUTPUT_DEPENDENCY_COMMANDS to 
function as a single shell command (ie. make the {} part of 
_AM_OUTPUT_DEPENDENCY_COMMANDS), rather than having to adjust every call site 
(are you sure that you caught all the call sites?).  Besides,

|| { _AM_OUTPUT_DEPENDENCY_COMMANDS }

looks weird, since normal shell syntax needs a ; in there, and this looks like 
a syntax error until you realize there is an m4 macro involved.

> 
> Attachment (automake-depout.patch): application/octet-stream, 556 bytes

Can you convince your mailer to send patches with a text MIME type, as it makes 
inline reviewing easier?

-- 
Eric Blake