Re: [PATCH 11] Fix LAZY_TEST_SUITE handling and $(TEST_SUITE_LOG) recreation.

[Akim Demaille]

Le 14 mars 09 à 14:46, Ralf Wildenhues a écrit :

> * Akim Demaille wrote on Sat, Mar 14, 2009 at 02:25:03PM CET:
> > FWIW, I also noticed that we sometimes had tests that were removed/
> > renamed that were still marked as XFAILs.  So I use this in some of  
> > my
> > test suites:
>
> Why are these not simply treated as hard failures?

Hum, I don't understand what you mean here, they are.  My code checks  
that members of XFAIL_TESTS and TFAIL_TESTS exist, and reports the  
missing ones.

Or maybe your question is "how come this was not noticed when the test  
were removed the TESTS"?  I have to confess that I am no longer  
filling TEST by hand, and I don't want to go into the nightmare of  
generating Makefile snippets either.  I basically rely on git to get  
the list of tests:

> tests = $(call ls_files,$(TESTS))
> TEST_LOGS = $(tests:.chk=.log)

with ls_files which wraps a call to "git ls-files".  Well, actually  
it's a call to a (ship) wrapper that use git when it is available,  
otherwise uses find.  Attached for the curious ones.

> # ls_files_in_dir DIR GLOBBING-PATTERNS
> # -------------------------------------
> # The files in DIR that match the GLOBBING-PATTERNS.
> #
> # The GLOBBING-PATTERNS are put in single quotes to avoid being
> # caught by the shell.
> ls_files_in_dir =                                                       \
>   $(or                                                                  \
>     $(shell $(build_aux_dir)/ls-files -s $(1) $(patsubst %,'%', 
> $(2))),	\
>     $(error ls-files in $(1) returned nothing for: $(2)))
>
> # ls_files GLOBBING-PATTERNS
> # --------------------------
> # The files in $(srcdir) that match the GLOBBING-PATTERNS.
> ls_files =                                      \
>   $(call ls_files_in_dir,$(srcdir),$(1))
>
> EXTRA_DIST += $(build_aux_dir)/ls-files

I defined TEST_LOGS from tests and tests from TESTS so that I can run

        make check TESTS='2.x/*.chk *uob*'

to have globbing on the list of the tests to run.  Partial runs of the  
test suite have proved to be a very valuable feature.

So it is quite easy to add, remove, rename tests, and in the end find  
that XFAIL_TESTS was not updated.

ls-files
Description: Binary data