Re: [PATCH 1/3] Vala: Fix build when using per-target VALAFLAGS

[Ralf Wildenhues]

Hi Jürg,

* Jürg Billeter wrote on Fri, May 15, 2009 at 03:50:55PM CEST:
> This does not yet implement full per-target support for VALAFLAGS,
> however, this change at least fixes building when there is only one
> target per source file, which is the most common situation.

When testing vala5.test with this, you get several rules including
commands for baz.c in src/Makefile.  This will cause failures for
non-GNU make, and thus needs to be fixed.

Also, this change now would make
  bin_PROGRAMS = foo bar
  foo_SOURCES = foo.vala
  bar_SOURCES = foo.vala
  bar_VALAFLAGS = -D bar

a possibly silently broken build, IIUC.  That deserves at least a
comment in the manual; see the suggestion below.  I haven't thought
about a consistency check in automake.in; fixing the issue would be
effort spent better.

Please note that I'm really close to finishing 1.11, and considering
to postpone this change unless there is an easy way out.

Thanks,
Ralf

diff --git a/doc/automake.texi b/doc/automake.texi
index e877942..8241d7b 100644
--- a/doc/automake.texi
+++ b/doc/automake.texi
@@ -6653,6 +6653,10 @@ libfoo_la_SOURCES = foo.vala
 @end example
 @end vtable
 
+Note that currently, you cannot use per-target @code{*_VALAFLAGS}
+(@pxref{Renamed Objects}) to produce different C files from one Vala
+source file.
+
 
 @node Support for Other Languages
 @comment  node-name,  next,  previous,  up