automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: AM_DISTCHECK_CONFIGURE_FLAGS


From: Ralf Wildenhues
Subject: Re: AM_DISTCHECK_CONFIGURE_FLAGS
Date: Sun, 23 Aug 2009 20:10:24 +0200
User-agent: Mutt/1.5.20 (2009-08-09)

Hello Sergey,

sorry for the delay.

* Sergey Poznyakoff wrote on Fri, Jul 31, 2009 at 11:38:04AM CEST:
> Sometimes it is necessary to always use certain configure
> options during distcheck. For example, in GNU cpio we do
> not build `mt' by default, but we'd like to always build
> it during distcheck, to ensure that nothing went wrong with
> it. That could be achieved if automake used
> AM_DISTCHECK_CONFIGURE_FLAGS variable, along with
> DISTCHECK_CONFIGURE_FLAGS.

Why can't you use DISTCHECK_CONFIGURE_FLAGS for that?  After all,
distcheck is more or less a developer target anyway.

> How about the attached patch?

I'm not fully convinced about the need of this yet, but the patch is
lacking a ChangeLog entry, a test, and updates of NEWS and the manual.
(You don't need to do this, but it may take me a bit.)

Thanks,
Ralf

> --- a/lib/am/distdir.am
> +++ b/lib/am/distdir.am
> @@ -472,7 +472,7 @@ distcheck: dist
>  ?GETTEXT?        --with-included-gettext \
>  ## Additional flags for configure.  Keep this last in the configure
>  ## invocation so the user can override previous options.
> -         $(DISTCHECK_CONFIGURE_FLAGS) \
> +         $(AM_DISTCHECK_CONFIGURE_FLAGS) $(DISTCHECK_CONFIGURE_FLAGS) \
>         && $(MAKE) $(AM_MAKEFLAGS) \
>         && $(MAKE) $(AM_MAKEFLAGS) dvi \
>         && $(MAKE) $(AM_MAKEFLAGS) check \




reply via email to

[Prev in Thread] Current Thread [Next in Thread]