[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/8] Work around a bug of AT&T Ksh w.r.t. ${1+"$@"}
From: |
Stefano Lattarini |
Subject: |
[PATCH 4/8] Work around a bug of AT&T Ksh w.r.t. ${1+"$@"} |
Date: |
Mon, 1 Feb 2010 17:01:00 +0100 |
User-agent: |
KMail/1.12.1 (Linux/2.6.30-2-686; KDE/4.3.2; i686; ; ) |
Work around a bug of AT&T Ksh w.r.t. ${1+"$@"}
* tests/defs.in (run_command): Don't use the expression
`${1+"$@"}', as it might trigger a bug of AT&T Korn shell.
From 8d9e6fa0eb0a1ab74a0bb200fcbf3da2c940b256 Mon Sep 17 00:00:00 2001
From: Stefano Lattarini <address@hidden>
Date: Sun, 13 Dec 2009 16:12:49 +0100
Subject: [PATCH 4/8] Work around a bug of AT&T Ksh w.r.t. ${1+"$@"}
* tests/defs.in (run_command): Don't use the expression
`${1+"$@"}', as it might trigger a bug of AT&T Korn shell.
---
ChangeLog | 6 ++++++
tests/defs.in | 11 +++++++++--
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index ee1227f..7713265 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
2009-01-31 Stefano Lattarini <address@hidden>
+ Work around a bug of AT&T Korn shell w.r.t. `${1+"$@"}'.
+ * tests/defs.in (run_command): Don't use the expression
+ `${1+"$@"}', as it might trigger a bug of AT&T Korn shell.
+
+2009-01-31 Stefano Lattarini <address@hidden>
+
Testsuite: remove AUTOMAKE_fails and AUTOMAKE_run
* tests/defs.in (AUTOMAKE_fails, AUTOMAKE_run): Removed.
* tests/README: Suggest to use `run_command -e 1 $AUTOMAKE',
diff --git a/tests/defs.in b/tests/defs.in
index 3aa88d5..44068bd 100644
--- a/tests/defs.in
+++ b/tests/defs.in
@@ -437,10 +437,17 @@ run_command ()
0) echo "run_command: missing COMMAND argument" >&2; Exit 99;;
*) run_cmd=$1; shift;;
esac
+ # The use of `${1+"$@"}' might trigger a bug of some Korn shells
+ # if only one *empty* argument is given.
+ if test $# -eq 0; then
+ run_evald_cmd='"$run_cmd"'
+ else
+ run_evald_cmd='"$run_cmd" "$@"'
+ fi
if test x"$run_mix_stdout_and_stderr" = x"yes"; then
- run_evald_cmd='"$run_cmd" ${1+"$@"} >stdall 2>&1'
+ run_evald_cmd="$run_evald_cmd >stdall 2>&1"
else
- run_evald_cmd='"$run_cmd" ${1+"$@"} >stdout 2>stderr'
+ run_evald_cmd="$run_evald_cmd >stdout 2>stderr"
fi
# NOTE: do not use the apparently simpler construct:
# if eval "$run_evald_cmd"; then
--
1.6.5
- [PATCH 0/8] Towards a Zsh-compatible Automake testsuite, Stefano Lattarini, 2010/02/01
- [PATCH 1/8] Testsuite: avoid Zsh-related problem with `set -x', Stefano Lattarini, 2010/02/01
- [PATCH 2/8] Maintainer-check: warn against zsh xtrace bug, Stefano Lattarini, 2010/02/01
- [PATCH 3/8] Testsuite: remove AUTOMAKE_fails and AUTOMAKE_run, Stefano Lattarini, 2010/02/01
- [PATCH 4/8] Work around a bug of AT&T Ksh w.r.t. ${1+"$@"},
Stefano Lattarini <=
- [PATCH 5/8] Improve description of `run_command' in README, Stefano Lattarini, 2010/02/01
- [PATCH 6/8] Tests: prefer run_command over direct stdout redirection(s), Stefano Lattarini, 2010/02/01
- [PATCH 7/8] Testsuite: run_command can now set env variables, Stefano Lattarini, 2010/02/01
- [PATCH 8/8] Testsuite: avoid redundant use of the `env' utility., Stefano Lattarini, 2010/02/01